大家看看这个JAVABEAN是不是写的有毛病？？

package db;import java.sql.*;public class ConnMsSQL { String sDBDriver = "com.microsoft.jdbc.sqlserver.SQLServerDriver"; String sConnStr = "jdbc:microsoft:sqlserver://localhost:1433;DatabaseName=ghyghost"; String username = "ghyghost", password = "gaohongyanghy"; Connection connect = null; ResultSet rs = null; public ConnMsSQL() {
try {
Class.forName(sDBDriver);
} catch (java.lang.ClassNotFoundException e) {
System.err.println(e.getMessage());
}
} public ResultSet executeQuery(String sql) {
try {
connect = DriverManager.getConnection(sConnStr, username, password);
Statement stmt = connect.createStatement();
rs = stmt.executeQuery(sql);
} catch (SQLException ex) {
System.err.println(ex.getMessage());
}
return rs;
} public int executeUpdate(String sql) {
int result = 0;
try {
connect = DriverManager.getConnection(sConnStr, username, password);
Statement stmt = connect.createStatement();
result = stmt.executeUpdate(sql);
} catch (SQLException ex) {
System.err.println(ex.getMessage());
}
return result;
}
}
调用如下：<%request.setCharacterEncoding("GBK"); String insert_sql = "insert into mainbbs(title,name,email,qq,page,text,todate) values(";
insert_sql = insert_sql + "'" + request.getParameter("title") + "'"
+ ",";
insert_sql = insert_sql + "'" + request.getParameter("name") + "'"
+ ",";
insert_sql = insert_sql + "'" + request.getParameter("email") + "'"
+ ",";
insert_sql = insert_sql + "'" + request.getParameter("qq") + "'"
+ ",";
insert_sql = insert_sql + "'" + request.getParameter("page") + "'"
+ ",";
insert_sql = insert_sql + "'" + request.getParameter("text") + "'"
+ ",";
insert_sql = insert_sql + "'"
+ new java.util.Date().toLocaleString() + "'";
insert_sql = insert_sql + ")";
out.print(insert_sql); conn.executeUpdate(insert_sql); response.sendRedirect("mybbs.jsp");
%>是不是:
public int executeUpdate(String sql) {
int result = 0;
try {
connect = DriverManager.getConnection(sConnStr, username, password);
Statement stmt = connect.createStatement();
result = stmt.executeUpdate(sql);
} catch (SQLException ex) {
System.err.println(ex.getMessage());
}
return result;
}
中的stmt没有close()????忘写了？？？