请教一个存储过程

Question

for .. in .. loop 放在一行
试试

Answer 1

rec_ps_syrkdj -〉rec
去掉close cur_ps_syrkdj;这一句，
游标是隐式打开的，自动关闭

Answer 2

rec_ps_syrkdj cur_ps_syrkdj%rowtype;  可以不要

Answer 3

create or replace procedure insert_into_tmp is
  
  cursor cur_ps_syrkdj 
  is
    select syrkbh,jmsfzh,xm,xzz,sfsbsq,tbr,tbsj,yzz1,yzz2,bm,xb,csrq,mz,jg,whcd,
           zy,fwcs,jucun,minzu,yzz3,ytbr
    from ps_syrkdj;  v_count number(3);
  
  rec_ps_syrkdj cur_ps_syrkdj%rowtype;
  
begin
  v_count:=1
  for rec_ps_syrkdj in cur_ps_syrkdj 
  loop
       insert into demo_syrkdj(syrkbh,jmsfzh,xm,xzz,sfsbsq,tbr,tbsj,yzz1,yzz2,
                              bm,xb,csrq,mz,jg,whcd,zy,fwcs,jucun,minzu,yzz3,
                              ytbr,sj,flag)
           values (rec_ps_syrkdj.syrkbh,rec_ps_syrkdj.jmsfzh,rec_ps_syrkdj.xm,rec_ps_syrkdj.xzz,rec_ps_syrkdj.sfsbsq,rec.tbr,rec_ps_syrkdj.tbsj,rec_ps_syrkdj.yzz1,rec_ps_syrkdj.yzz2,rec_ps_syrkdj.bm,
rec_ps_syrkdj.xb,rec_ps_syrkdj.csrq,rec_ps_syrkdj.mz,rec_ps_syrkdj.jg,rec.whcd,
rec_ps_syrkdj.zy,rec_ps_syrkdj.fwcs,rec_ps_syrkdj.jucun,rec_ps_syrkdj.minzu,rec.yzz3,
                   rec_ps_syrkdj.ytbr,trunc(sysdate),'1');
       if v_count = 500 then
          commit;
          v_count:=1;
       end if;
       v_count:=v_count+1;
   end loop;
   close cur_ps_syrkdj;
   commit;
end insert_into_tmp;

Answer 4

v_count:=1;
加上分号
同意 jxc(GameHeart)

Answer 5

create or replace procedure insert_into_tmp is
  
  cursor cur_ps_syrkdj 
  is
    select syrkbh,jmsfzh,xm,xzz,sfsbsq,tbr,tbsj,yzz1,yzz2,bm,xb,csrq,mz,jg,whcd,
           zy,fwcs,jucun,minzu,yzz3,ytbr
    from ps_syrkdj;  v_count number(3);
  
  rec_ps_syrkdj cur_ps_syrkdj%rowtype;
  
begin
  v_count:=1；
  for rec_ps_syrkdj in cur_ps_syrkdj 
  loop
       insert into demo_syrkdj(syrkbh,jmsfzh,xm,xzz,sfsbsq,tbr,tbsj,yzz1,yzz2,
                              bm,xb,csrq,mz,jg,whcd,zy,fwcs,jucun,minzu,yzz3,
                              ytbr,sj,flag)
           values (rec_ps_syrkdj.syrkbh,rec_ps_syrkdj.jmsfzh,rec_ps_syrkdj.xm,rec_ps_syrkdj.xzz,rec_ps_syrkdj.sfsbsq,rec.tbr,rec_ps_syrkdj.tbsj,rec_ps_syrkdj.yzz1,rec_ps_syrkdj.yzz2,rec_ps_syrkdj.bm,
rec_ps_syrkdj.xb,rec_ps_syrkdj.csrq,rec_ps_syrkdj.mz,rec_ps_syrkdj.jg,rec.whcd,
rec_ps_syrkdj.zy,rec_ps_syrkdj.fwcs,rec_ps_syrkdj.jucun,rec_ps_syrkdj.minzu,rec.yzz3,
                   rec_ps_syrkdj.ytbr,trunc(sysdate),'1');
       if v_count = 500 then
          commit;
          v_count:=1;
       end if;
       v_count:=v_count+1;
   end loop;
   close cur_ps_syrkdj;
   commit;
end insert_into_tmp;
同意加分号。